Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix phpstan #36

Merged
merged 4 commits into from
Apr 23, 2024
Merged

ci: fix phpstan #36

merged 4 commits into from
Apr 23, 2024

Conversation

millnut
Copy link
Member

@millnut millnut commented Sep 26, 2023

Same as localgovdrupal/localgov_project#131 but for Microsites

@finnlewis finnlewis changed the base branch from 3.x to 4.x April 2, 2024 11:44
@finnlewis
Copy link
Member

@millnut not sure why we didn't merge this yet, so changing this to target 4.x branch, does it still look right?

@millnut
Copy link
Member Author

millnut commented Apr 23, 2024

@finnlewis looks good to me

@ekes
Copy link
Member

ekes commented Apr 23, 2024

Schema errors and some deprecated code checks.

I'll get this merged, so tests down for the rest of all the things run against it.

@ekes ekes merged commit 19ed58c into 4.x Apr 23, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants